expression: add missing setPbCode() for some arithmetic function #12864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Signed-off-by: Lonng <[email protected]>
|
/run-all-tests |
|
/run-all-tests tidb-test=pr/924 |
Codecov Report
@@ Coverage Diff @@
## master #12864 +/- ##
===========================================
Coverage 80.1368% 80.1368%
===========================================
Files 465 465
Lines 107858 107858
===========================================
Hits 86434 86434
Misses 14983 14983
Partials 6441 6441 |
H-ZeX
approved these changes
Oct 22, 2019
H-ZeX
added
the
status/can-merge
H-ZeX
removed
the
status/can-merge
|
/run-all-tests |
H-ZeX
changed the title
H-ZeX
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng [email protected]
What problem does this PR solve?
The MOD function does not call the
setPbCodewhile pushing down to coprocessor, which will cause an unexpected error:Error 1105: other error: [components/tidb_query/src/expr/scalar_function.rs:516]: unexpected arguments: sig CastIntAsInt with 2 args.What is changed and how it works?
Add the missing call.
Check List
Tests
Release note
setPbCodecall for theMODfunction to avoid unexpected error while pushing theMODto the coprocessor.